Slimmer toolbars on repository page

MrNaif2018 commented 3 years ago

Description

I am not 100% sure, but few updates back I have noticed that all toolbars (showing latest commit, issue filter, etc.) are now slimmer than before (looks like removed paddings). It was not so in the previous versions, and also not in the original github UI. Sorry if I missed some change, but I definitely remember it was not so before, see the screenshots below.

Screenshot

( Showing on my own repo, as I don't have any other screenshots from older versions of the script)

Current toolbars:

In the repo page:

In the issues filter:

Pull requests filter:

How was it back then:

At the initial versions of the script:

Few months after the creation of the script:

Other information

Link to page with the issue: Any repository page, for example, my repo
Web Archive example: Web archive seems to be unavailable now, see the screenshots above, will add an example when it's back up, but it's easy to find out
Browser: Firefox 86.0, tried in Chrome 89.0.4389.90, same issue
Operating System: Linux Mint 20.1 XFCE 64 bit
GitHub-Defreshed version: 4.2.1

Kir-Antipov commented 3 years ago

Not a bug, but a feature :)

Yep, toolbars definitely lost a few pixels, but it was intentional. At the moment, with the help of Microsoft, they have grown to insane proportions:

wtf

And I really don't know why these guys are so much into wasting space...

Web archive seems to be unavailable now, see the screenshots above, will add an example when it's back up, but it's easy to find out

Well, it's up now (at least for me), so I've just used the link you gave me earlier:

before

With GitHub-Defreshed:

now

So, yeah, it seems like I overdid slimming a little bit (38.3 < 43.6), but did I really? As for me, even "golden age" toolbar was kinda plumper than it should be. Anyway, as always, I'm open for suggestions, so I can make this thing optional :) Should I?

MrNaif2018 commented 3 years ago

Thank you for replying! Yeah, I checked the recent UI and it's now ridiculously wide. Not really an issue to me, just something I noticed and wanted to let you know (I am just used to old style visually). I think it is fine, but if you add this option it would be great. Don't want to request some features which aren't very important and are very subjective. I will close the issue, it's up to you whether to add this feature or not, this script is already helping lots of people! Thank you very much.

Kir-Antipov commented 3 years ago

something I noticed and wanted to let you know

Thanks a lot! Sometimes it's really helpful as I don't always notice changes made by Microsoft :)

Don't want to request some features which aren't very important and are very subjective

Nothing to worry about: a lot of stuff about UI in general is "not very important" and "subjective", but all these small features form an interface we're comfortable with

it's up to you whether to add this feature or not

I think I'll ship it with a new version. Right now I have some things to do, so it will be a week or something like this

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MrNaif2018 commented 3 years ago

Not stale (:

Kir-Antipov commented 3 years ago

Usually @stale closes posts, the authors of which have disappeared and stopped responding. In my case, it's a little bit different:

do something...

Kir-Antipov / GitHub-Defreshed