Kir-Antipov / cubes-without-borders

A mod that allows you to play Minecraft in a borderless fullscreen window
MIT License
18 stars 8 forks source link

borderless option not appearing with iris 1.8 and sodium 0.6 #30

Closed sasquott closed 3 weeks ago

sasquott commented 3 months ago

MC version 1.21 & 1.21.1 both showing only on/off radio box for Fullscreen, no Borderless option appearing.

CwB version 2.1.1, tried with and without Reeses options and also Sodium Extra, still no Borderless option

sasquott commented 3 months ago

ugh, nvm - must be a mod clash, works fine with just those mods, will post which when I find it

sasquott commented 3 months ago

actually, scratch that, it actually works with the options.txt file set to fullscreen mode=2 and fullscreen=false but no menu option shows

Kir-Antipov commented 2 months ago

Also, you can always press Shift + P to open the vanilla video settings when you're on the Sodium options screen.

Anyways, if you identify the mod that breaks CWB's Sodium integration, please let me know, and I'll look into it!

sasquott commented 2 months ago

hmmm, interesting, so as I've been using this mod for a while, every time I've updated my instance, the setting has always been in the txt file so I haven't noticed this issue. After testing a new install, even with just Sodium 0.6, iris 1.8 and just CWB, I can only see the borderless option if I use shift+p - it's not there on normal sodium menu interface. No other mods involved. Screenshot 2024-08-26 104532 Screenshot 2024-08-26 104702 Screenshot 2024-08-26 104719

Surgeol commented 2 months ago

yeah, same problem as above, i have sodium 0.6.0beta1, Iris 1.8.0beta3, and mc version 1.21.

CottonCandieBoop commented 2 months ago

I get the same issue (it doesn't show in the Sodium menu) but at some point when using the mod long enough without changing anything or actively using the Borderless option, it just gave me the borderless option and I was able to use it. I have no clue what changed, because I just kinda accepted it and moved on until I made a new instance and needed to reapply the setting. The Shift+P thing works great, though!

AkalixFrost commented 2 months ago

Getting the same issue as described by others. Only thing related I could find was: [17:27:52] [main/WARN]: @Mixin target me.jellysquid.mods.sodium.client.gui.SodiumGameOptionPages was not found cubes-without-borders.sodium.mixins.json:SodiumGameOptionPagesMixin from mod cubes-without-borders

JustablockCode commented 1 month ago

same

JustablockCode commented 1 month ago

image image

Kir-Antipov commented 1 month ago

The Sodium mixin no longer works because they've changed the root namespace from me.jellysquid to net.caffeinemc. I.e., me.jellysquid.mods.sodium.client.gui.SodiumGameOptionPages no longer exists and should now be referred to as net.caffeinemc.mods.sodium.client.gui.SodiumGameOptionPages. I'll update the reference a bit later.

Once again, don't worry, as this doesn't break the mod's functionality. You can still use Shift+P to get to the vanilla settings.

Trudol commented 1 month ago

Same problem. Shift+P ain't working. How do i can turn this setting on in config file ? p.s. Oh. After restart it's on. Fine

itsnotalexthere commented 1 month ago

Can confirm that 0.6.0 makes the mod crash, not the client, since the net.caffeinemc offers only the API and Desktop parts, idk why

itsnotalexthere commented 1 month ago

Any updates on this?

DaPiCu commented 1 month ago

The bug still exists in version 0.6... easy fix if you switch to Sodium version 0.5, for example.

Kir-Antipov commented 3 weeks ago

Since v3.0.0, the mod has discontinued support for Sodium versions <=0.5 in favor of version 0.6 and, hopefully, above.