search

Kir-Antipov / mc-publish

🚀 Your one-stop GitHub Action for seamless Minecraft project publication across various platforms.
MIT License
216 stars 19 forks source link

[Regression] Tokens cannot be omitted via empty strings #106

Open Kir-Antipov opened 5 months ago

Kir-Antipov commented 5 months ago

Discussed in https://github.com/Kir-Antipov/mc-publish/discussions/103

Originally posted by **MattiDragon** January 20, 2024 I'm using this action, wrapped in a [custom workflow](https://github.com/MattiDragon/MattiDragon/blob/main/.github/workflows/publish-mc-mod.yaml) that does other things. I recently updated my version from `v3.2` to `v3.3.0` and something seems to have broken with the handling of missing tokens. One my projects isn't published on curseforge, so I don't provide a token or project it in [its workflow](https://github.com/MattiDragon/nodeflow/blob/1.20.4/.github/workflows/publish.yaml). This used to work, but now I'm getting an error that the curseforge project doesn't exist. This shouldn't happen as no token is provided, unless mc-publish decided to pick up the unused `CURSEFORGE_TOKEN` actions secret without me giving it as input (the token is there because I sync my tokens to all mods that need any of them). I'm just confused as to where mc-publish is getting something it thinks is a curseforge token (it should ignore empty strings, right?)