Add user agent to mc-publish, as required by the API terms for Modrinth

Kir-Antipov / mc-publish

🚀 Your one-stop GitHub Action for seamless Minecraft project publication across various platforms.

MIT License

228 stars 20 forks source link

Add user agent to mc-publish, as required by the API terms for Modrinth #58

Closed pandaninjas closed 1 year ago

pandaninjas commented 1 year ago

It will also get blocked by Cloudflare if it has no user agent header. This causes problems as shown https://canary.discord.com/channels/734077874708938864/783153806531100673/1092126127360852049 (requires you to be in https://discord.gg/modrinth-734077874708938864)

srnyx commented 1 year ago

When I was setting up my User Agent for my API I was told it'd be beneficial to include the project that's using the API and the API version. Makes it easier for Modrinth to know exactly who's making the requests. I'm not sure how to do that so someone else will have to make the changes.

Kir-Antipov commented 1 year ago

Their suggestions on User Agents can be found here.

I took the basic idea of username/project (contact info) and settled on Kir-Antipov/mc-publish (https://github.com/Kir-Antipov/mc-publish/issues/new).

Kir-Antipov commented 1 year ago

Was implemented in 5e2adc2d098f406501b59e0696e0f8c23c38b369.