search

Kir-Antipov / mc-publish

🚀 Your one-stop GitHub Action for seamless Minecraft project publication across various platforms.
MIT License
216 stars 19 forks source link

[Feature Request] Hangar support #62

Open Ghost-chu opened 1 year ago

Ghost-chu commented 1 year ago

Hanger: https://hangar.papermc.io/ API: https://hangar.papermc.io/api-docs

Andre601 commented 1 year ago

For sake of info and transparency (I suppose) am I mentioning my discussion about hangar, which brings some current limitations that mc-publish can't bypass or find a neat workaround for without heavy rewrites (Based on the author's reply).

65

Additionally, there is currently a Feature Request open that may help solve this issue if Hangar adds the required API paths for it... Link: https://github.com/HangarMC/Hangar/issues/805

MommyHeather commented 4 weeks ago

I don't suppose this has been considered since the old activity on this issue? I understand that a LOT about this workflow has changed since then.

Kir-Antipov commented 3 weeks ago

It has been and still is considered. Whenever Hangar has a functional API, I would be more than happy to implement support for it here.

MommyHeather commented 3 weeks ago

Can I ask what's wrong with its current api?

Andre601 commented 3 weeks ago

Can I ask what's wrong with its current api?

For once, you need to do 2 requests:

Kir-Antipov commented 3 weeks ago

For once, you need to do 2 requests

That's just annoying, but it's not really the problem.

Can I ask what's wrong with its current api?

You can refer to #65, where we discussed this with Andre601. Nothing has changed since then, except that after a whole year of "active development" there is somehow even less documentation than before.

To recap, Hangar's API is logically incompatible with mc-publish. Here, we publish a single mod/plugin/modpack/whatever to multiple platforms. There, they require you to publish multiple plugin versions to their platform in one go. While it's their project and they are free to succumb to whatever madness they prefer, their API is currently severely underdeveloped - they don't even have a PATCH route, so you either publish everything at once and just full send it, or you do not publish anything at all; there's nothing in between.

Until there is a way to publish different plugin versions separately (e.g., at least by PATCHing an existing combined Hangar "version"), there's nothing I can do. You may kindly ask the developers to implement such functionality or even contribute it yourself to accelerate the process, as it seems to be very stuck at the moment.

MommyHeather commented 3 weeks ago

Ah, I see - after reading through #65, I do see why their post requests for version uploads don't suffice. It's a bit of a shame, but I understand.