Kir-Antipov / mc-publish

🚀 Your one-stop GitHub Action for seamless Minecraft project publication across various platforms.
MIT License
216 stars 19 forks source link

Allow specifying the environment of the mod (CurseForge only) #64

Open Steveplays28 opened 1 year ago

Steveplays28 commented 1 year ago

Since CurseForge has a checkbox for the environment (server/client) that is bound to the uploaded files (instead of the project, like Modrinth), every time a file is uploaded this checkbox needs to be set. Is there any way to set this in the config that I'm missing?

Kir-Antipov commented 1 year ago

No, at the moment this is impossible. They hadn't had this feature when the last version of mc-publish was published. I hope to implement support for environments in v4.1 (it won't be CurseForge-only feature).

Steveplays28 commented 1 year ago

Alright, thanks. Just curious, how are you going to implement this for GitHub and Modrinth?

Kir-Antipov commented 1 year ago

As you pointed out, it is possible to specify the environments supported by your mod on Modrinth as well. The only difference is that CurseForge allows you to specify environments per version, while on Modrinth, it is a project-wide option. I believe it would be reasonable to assume that you would want your Modrinth project to reflect the capabilities of the latest version of your mod. Therefore, mc-publish could update the current settings of the project based on the version being published, if necessary.

As for GitHub, the environment input would remain unused, just as github-loaders, github-dependencies, and github-game-versions. There's a discussion on that (#60), so you may leave you suggestions and thoughts on how it could be implemented there.

jh-devv commented 9 months ago

+1