Kir-Antipov / mc-publish

🚀 Your one-stop GitHub Action for seamless Minecraft project publication across various platforms.
MIT License
216 stars 19 forks source link

1.8.1 isn't selected for CurseForge #81

Closed srnyx closed 12 months ago

srnyx commented 12 months ago
game-versions: ">=1.8.8"
game-version-filter: releases

File published: https://dev.bukkit.org/projects/annoying-api/files/4646459 1.8.1 is the only version not selected

Kir-Antipov commented 12 months ago

Honestly, your issue isn't entirely clear to me. I would greatly benefit from a more detailed explanation of the problem you're experiencing. Also, just to note, the URL you've included seems to lead to a 404 page.

As for your configuration, it produces the following set of suitable CurseForge version IDs:

[
  // Bukkit Plugins
  [
    9994, 9974, 9973, 9561,
    9560, 9261, 9190, 9016,
    8897, 8849, 8503, 7915,
    7667, 7330, 7105, 6588,
    630,  591,  585,  531,
  ],

  // Modpacks, Customization, Resource Packs, and Worlds
  [
    9990, 9971, 9776, 9550, 9366, 9259,
    9186, 9008, 8857, 8830, 8516, 8152,
    8203, 8134, 8056, 8010, 7892, 7890,
    7722, 7675, 7664, 7469, 7413, 7361,
    7344, 7318, 7132, 7107, 7081, 6756,
    6711, 6580, 6452, 6451, 6317, 6170,
    6160, 6144, 6084, 6085, 5997, 5998,
    5946, 5806, 5703,
  ],

  // Addons
  [
    9993, 9970, 9792, 9552,
    9551, 9260, 9189, 8899,
    8504, 7997, 7996, 7436,
    7435, 7434, 7433, 7432,
    7431, 7430,
  ],
]

Obviously, we are particularly interested in the "Bukkit" section. So, the versions being used in your case are these ones:

[
  9994, // 1.20.1
  9974, // 1.20
  9973, // 1.19.4
  9561, // 1.19.3
  9560, // 1.19.2
  9261, // 1.19.1
  9190, // 1.19
  9016, // 1.18.2
  8897, // 1.18.1
  8849, // 1.18
  8503, // 1.17
  7915, // 1.16
  7667, // 1.15
  7330, // 1.14
  7105, // 1.13
  6588, // 1.12
  630,  // 1.11
  591,  // 1.10
  585,  // 1.9
  531,  // 1.8
]

The output seems normal to me given your game version constraint. Without a clear understanding of your concerns or the exact issue you're facing, it's challenging to provide a more specific answer. Therefore, I'd kindly request you to elaborate on the problem you're experiencing, providing as much detail as possible.

srnyx commented 12 months ago

Also, just to note, the URL you've included seems to lead to a 404 page.

Sorry, I had deleted that version, here's a new one: https://dev.bukkit.org/projects/annoying-api/files/4646474

The output seems normal to me given your game version constraint.

It's missing 1.8.1: image

Kir-Antipov commented 12 months ago

Oh, it actually exists, what the... I was under the strong impression that they didn't differentiate Minecraft builds for Bukkit plugins after 1.7 and before 1.18. But it seems that there are three (out of ten, lol) 1.8-related versions presented in their API:

{
  "id": 531,
  "gameVersionTypeID": 1,
  "name": "1.8",
  "slug": "1-8",
  "apiVersion": null
},
{
  "id": 532,
  "gameVersionTypeID": 1,
  "name": "1.8.1",
  "slug": "1-8-1",
  "apiVersion": null
},
{
  "id": 568,
  "gameVersionTypeID": 1,
  "name": "1.8.3",
  "slug": "1-8-3",
  "apiVersion": null
},

1.8.2 || >=1.8.4 <=1.8.9 do not exist, and 1.8.3 is not even displayed in the GUI for some reason.

Anyway, considering that this is a territory of the trademarked CurseForge madness, I wouldn't call this behavior a bug - mc-publish cannot find 1.8.8, so it fallbacks to 1.8, assuming that it's a section that should include the version in question. And I don't really know, to be quite frankly honest with you, how to handle it better. So, maybe you can adjust your selector to >=1.8, if you really care about 1.8.1 and not about other 8 other 1.8.x versions, or just forget about it at all, so we could call it a day? xD

srnyx commented 12 months ago

So, maybe you can adjust your selector to >=1.8, if you really care about 1.8.1 and not about other 8 other 1.8.x versions, or just forget about it at all, so we could call it a day? xD

I completely forgot that I had >=1.8.8 and not >=1.8, 1.8 being selected (which is correct) must've confused me lmao Then yeah, this isn't a bug, my apologies!