Kir-Antipov / sync-fabric

One mind. Many bodies.
MIT License
17 stars 13 forks source link

Incompatibility with Immersive Portals Mod #28

Open Chill907Gaming opened 2 years ago

Chill907Gaming commented 2 years ago

What happened?

When playing with the immersive portals mod, have the immersive portal loaded on your screen. When you switch shells, as long as you're switching shells in the same dimension you are usually fine but, switching shells from the overworld to the nether seems to give me an infinite loading screen. I believe this is because the nether is already loaded from the immersive portals mod. Switching from the nether to the overworld usually works but switching from the end to the overworld seems to give an infinite loading screen nearly every time.

Also an occasional crash happens when you try switching from the overworld to the end. it also happened when I first entered the end. I tried to switch shells to another shell in the same dimension [in the end], and my game crashed. loading my game back up and attempting to switch shells in the end worked just fine the second try.

Here is a crash report from the first time it crashed. There were no visible portals in this crash although if you know how the immersive portals mod does the end you would know that there is a one way portal [which doesn't get unloaded right away]. crash-2022-06-17_02.48.29-client.txt

Happens with shaders either on or off

To reproduce this

  1. Load minecraft 1.19 with iris and immersive portals installed with their dependencies (sodium and fabric api)
  2. Create a shell in the overworld (wait for it to finish)
  3. create a portal to the nether and go through.
  4. in the nether create an end portal using creative mode (looking back this could be the cause)
  5. Create a shell in the nether (you must wait for it to finish)
  6. Enter the end and create another shell there.
  7. change to a shell in a different dimension.
  8. infinite loading screen. [sometimes crash]
  9. if you dont get an infinite loading screen try placing a second nether portal.

Here is the log for the logs section. I cannot paste it as it is too long 2022-06-17-3.log

Version

sync-mc1.19-4.1

Minecraft Version

1.19

Fabric API Version

fabric-api-0.55.3+1.19

Installation Source

CurseForge

Logs

This is a log from when I first removed nearly all my mods to troubleshoot the problem. I loaded the same world that I had tested with my server's mods, that is why there are so many notices shown. You can see (in the crash report that I linked above) the other mods which I usually have installed. They didn't seem to cause any issues. I removed them all then added half of them back each time I tested the shell switching. I coudln't get the game to crash consistently, although the End crashes more than the nether when switching to and from the overworld.

Here is a log using only the mods listed below this issue's "Other Mods" section.

Other Mods

Tested with these mods:
- sodium mc1.19-0.4.2=build.16
- indium mc1.19-1.0.4
- fabric-language-kotlin-mc1.19-1.8.0+kotlin1.7.0
- fabric-api-0.55.3+1.19
- iris-mc1.19-1.2.5
- immersive portals-2.0.1-mc1.19-fabric
- sync-mc1.19-4.1

Adding the rest of my mods didn't affect the stability.

Additional Information

I am using an alpha version of Immersive portals for 1.19 as well as sodium and Iris. so I fully expect bugs and issues. Just trying to help hammer out any problems if I can. Thank you for your time and for reading all this gobbledygook. Also let me know if this is an issue that I should forward to Immersive portal's developers.

Kir-Antipov commented 2 years ago

It's the same as qouteall/ImmersivePortalsMod#1014. Workaround has not been found

Chill907Gaming commented 2 years ago

Ah thank you for telling me I did not know. Until then I can play with immersive portals disabled. This mod is worth it!

qouteall commented 1 year ago

The latest version of ImmPtl (in MC 1.19.3) does not have this check. Maybe the issue does not exist now.

Kir-Antipov commented 1 year ago

Cool! Thanks for telling me (and removing that restrictive check xD)! It shouldn't, because I saw nothing that should realistically cause problems with a single camera entity, which exists in one dimension and never crosses its borders