In the context of the network, many identifiers are unique and used extensively. For the purpose of maintaining the security of these unique identifiers, especially in relation to the utilization of prefixes, it is recommended that the usage of the character _ be prohibited for all users.
[ ] Unique identifiers should not be purely numerical. While they can include numbers, they must contain at least one non-numerical character.
[ ] Missing ValidateTokenDenom for token denom when adding token rate & token alias (Token module) and minting module (Layer 2 module). But this issue should be in consideration of potential merging of minting module with token module #664
@jgo121
After reviewing the ABR specification, it should be added here that unique identifiers should not be purely numerical. While they can include numbers, they must contain at least one non-numerical character.
Description
In the context of the network, many identifiers are unique and used extensively. For the purpose of maintaining the security of these unique identifiers, especially in relation to the utilization of prefixes, it is recommended that the usage of the character
_
be prohibited for all users.[ ] Identity Registrar : https://github.com/KiraCore/sekai/blob/1b8573dfe96c7d423df3e871c29ef9771f5baef3/x/gov/keeper/identity_registrar.go#L18-L21
[ ] SID roles: https://github.com/KiraCore/sekai/blob/1b8573dfe96c7d423df3e871c29ef9771f5baef3/x/gov/keeper/util.go#L92-L95
[ ] Spending Pool : https://github.com/KiraCore/sekai/blob/1b8573dfe96c7d423df3e871c29ef9771f5baef3/x/spending/types/keys.go#L30-L33
[ ] Missing
ValidateDappName
for dApp names[ ] Unique identifiers should not be purely numerical. While they can include numbers, they must contain at least one non-numerical character.
[ ] Missing
ValidateTokenDenom
for token denom when adding token rate & token alias (Token module) and minting module (Layer 2 module). But this issue should be in consideration of potential merging of minting module with token module #664