KiranAminPanjwani / LeatherHoard

A basic template for e-commerce website, designed with HTML, CSS and Bootstrap.
https://leatherhoard.netlify.app/
MIT License
44 stars 61 forks source link

Clean up filenames and folder organization #98

Closed terrifricker closed 2 years ago

terrifricker commented 2 years ago

🎇 Description

Some files are not named consistently with the current files. Some files are not located in the proper html and css folders. Pathnames to css links and tags will need to be updated at the same time. These are the exact changes I see as of this moment.

File name changes PrivacyPolicy.html to privacy-policy.html logincss.css to login.css privacyPolicy.css to privacy-policy.css

Files to move into html folder login.html privacy-policy.html

Files to move into css folder login.css

update css links with correct pathname privacy-policy.html login.html

update all tags in each existing html file leading to privacy-policy.html login.html

Because these changes are best done with a fresh, clean main branch with no pull requests waiting, I understand that it may be cleanest for you as the maintainer to make these changes. I wanted to raise the issue and at least offer to make the changes.

đŸ–Œ Screenshots

No response

terrifricker commented 2 years ago

I am realizing that with a time difference of exactly 12 hours (I'm in Pacific, UTC -8) the timing could be difficult. Here are the corrections needed as of October 5, 1 am.

privacy-policy.html line 9 <link rel=”stylesheet” href=”../css/privacy-policy.css” />

login.html line 30 <link rel=”stylesheet” href=”../css/login.css” /> line 174 <a href=”../html/privacy-policy.html”>Privacy Policy</a></li>

index.html line 23, remove – doesn’t need link to logincss.css ? line 104 <a class=”nav-link” href=”html/login.html” />Login</a> line 773 <a href=”html/privacy-policy.html”>Privacy Policy</a></li>

about.html line 85 <a class=”nav-link” href=”../html/login.html”>Login</a> line 178 <a href=”../html/privacy-policy.html”>Privacy Policy</a></li>

products.html line 103 <a class=”nav-link” href=”../html/login.html”>Login</a>

KiranAminPanjwani commented 2 years ago

Sure 😊