Made changes in header!

runtimeerror11 commented 11 months ago

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

👨‍💻 Changes proposed:

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Changes made -

Logo image changed to actual text with same font and size parameters. Corresponding font link is added as internal style in-order to easily get it.
The href value of this text change to #. (initially though it refers to itself it was not working!).
Also commented the previously unreferenced code from styles.css

Description - Firstly the each page header consists of image as logo (i.e. Medsats) which doesn't not perfectly gel up with the background of the header. Thus, in-order to convert it into text I have found out the most relevant font, whose link I have mentioned in the internal styling format. Also made the appropriate changes in the positions of the stethoscope image and Medstats text symbol. The previous font related parameters are taken care in this change too, You can compare the image of logo used and the text in my change are almost alike.

Secondly as the Name of the organization is mentioned in anchor tag ,the href provided to it is not working(there is chance that this issue might be only on my side) but the change I have made will work any ways as it references to the top of page. I would like to highlight that the changes related to the header are made only on the home page(i.e. index.html) the same logo exits on other pages too! So if you agree the changes I made , I would like to proceed with same to the remaining pages.

**Also if I had made any blunder ,being a newbie , your suggestions are most Welcome !

Hope you get me back with reply! Thank you!**

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.
[ ] I have included comments in areas that may be difficult to understand.
[x] My changes have not introduced any new warnings.
[x] I have conducted a self-review of my code.
[x] I am a participant of Hacktoberfest 2023.

📷 [Screenshots]

Updated header pic-

📄 Note to reviewers

I would like to highlight that the changes related to the header are made only on the home page(i.e. index.html) the same logo exits on other pages too! So if you agree the changes I made , with your approval I would like to proceed with same on the remaining pages.

netlify[bot] commented 11 months ago

Deploy Preview for medstats-health-journal ready!

Name	Link
Latest commit	73a4a71977bd7532a294d9c77e647114ff7ebcfb
Latest deploy log	https://app.netlify.com/sites/medstats-health-journal/deploys/65398c34eeed6e0008c1f7fa
Deploy Preview	https://deploy-preview-139--medstats-health-journal.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

runtimeerror11 commented 11 months ago

@KiranAminPanjwani hope you get me back with this!!

KiranAminPanjwani commented 11 months ago

Your changes are not consistent across all the pages of the website.

runtimeerror11 commented 11 months ago

@KiranAminPanjwani Being a Newbie I was unable to change this branch in order to sync with the updated main branch. Thus I have made the new pr with new branch containing the changes made consistent over all the pages of the Project!

KiranAminPanjwani / MedStats