Add color legend - Githubissues

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.

MIT License

1.46k stars 198 forks source link

Add color legend #211

Open ohadschn opened 6 years ago

ohadschn commented 6 years ago

Nodes have different colors: yellow for warning, red for error, gray for info, blue for properties, etc. It would be nice to have some legend somewhere, or at least be able to hover over the rectangle / line and get the classification.

daveaglick commented 6 years ago

+1 to this - even though I know the colors pretty well by now, having a little legend on screen would save me that little bit of mental effort thinking "what does this mean again?"

ulln commented 5 years ago

+1 What does a grayed out target node mean? (Where) Is this documented?

KirillOsenkov commented 5 years ago

@ulln I wrote a quick answer here: https://github.com/KirillOsenkov/MSBuildStructuredLog/wiki/Viewer-UI

Apologies that this issue will likely remain open for a long time ;) There's higher priority/impact issues that I need to get to first.

daiplusplus commented 7 months ago

I noticed you have better icons in the Blazor version - if I were to port them over to the WPF version as an alternative to the colored rectangles and submitted it as a PR would you accept and merge it?

Notice how I said "alternative" instead of "replacement for" because UI changes tend to get people's backs up 😁
And rather than simply import those low-res PNGs/ICOs into the WPF XAML, I think I can track down - or recreate - SVG or XAML-vector-art versions of them - sound good?
And/or maybe also include a checkbox in the Help menu to show/hide a Legend bar in the UI?

KirillOsenkov commented 7 months ago

let me think about this on the weekend before you spend any time on it, it's a busy week but I hope to reply in a few days

daiplusplus commented 7 months ago

That’s why I asked you first 😸

KirillOsenkov commented 7 months ago

I think most people have gotten used to the current rectangles by now, so I doubt many people will switch to the actual icons. But maybe a (small?) share of users will appreciate it?

There are advantages to icons because colors might not be enough for colorblind users. For this reason in many cases I've added the word as well (target or task):

A couple of concerns for icons might be that rectangles are cheap to render, adding richer vector graphics might slow down perf? Also not sure about the Avalonia version, we could update just the WPF project.

Both pngs and XAML are embedded as resources in Microsoft.VisualStudio.ImageCatalog.resources.dll. https://glyphlist.azurewebsites.net/knownmonikers might be useful as well.

How passionate are you about this? I'm sorry, I hate saying no to people. 90% of me wants to say "we have bigger fish to fry" and let's not do this, but I may be swayed.