search

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.44k stars 191 forks source link

Two target invocations are collapsed into one, erroneously #504

Closed KirillOsenkov closed 3 years ago

KirillOsenkov commented 3 years ago 
<Project DefaultTargets="Build">

  <Target Name="A" Condition="$(X) == 'true'">
    <Message Text="Target A runs" Importance="high" />
  </Target>

  <Target Name="B" DependsOnTargets="A">
  </Target>

  <Target Name="C" >
    <PropertyGroup>
      <X>true</X>
    </PropertyGroup>
  </Target>

  <Target Name="D" DependsOnTargets="A">
  </Target>

  <Target Name="Build" DependsOnTargets="B;C;D">
  </Target>

</Project>

image

KirillOsenkov commented 3 years ago

The viewer doesn't expect this and collapses both invocations of Target A into the same node

KirillOsenkov commented 3 years ago

OK; this is better:

image