search

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.44k stars 191 forks source link

Simplify calling ITask.Execute #511

Closed 0xced closed 3 years ago

0xced commented 3 years ago

Making it easier to step into the Execute method with a debugger.

Also using a direct cast to ITask instead of as ITask because an InvalidCastException is easier to diagnose than a NullReferenceException several instructions later.

KirillOsenkov commented 3 years ago

Huh, I don’t remember why I used reflection here.

0xced commented 3 years ago

Yeah, that seemed unnecessary. Thanks for merging all my pull requests so quickly. 😃