I can't find release artifacts for Avalonia.

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.

MIT License

1.44k stars 190 forks source link

I can't find release artifacts for Avalonia. #550

Closed mfilippov closed 2 years ago

mfilippov commented 2 years ago

I found a guide about macOS builds: https://github.com/KirillOsenkov/MSBuildStructuredLog#building--running-the-avalonia-version-on-mac, but I can't find zip artefact on Releases.

slang25 commented 2 years ago

They can be found on the AppVeyor outputs, however recently they have stopped working for me on macOS, I think it's because they are built for M1 only, I have to build locally today.

KirillOsenkov commented 2 years ago

Yes I suppose I should be including the Mac artifacts when publishing a Release. Ideally we'd build both Intel and M1 bits.

slang25 commented 2 years ago

It looks like both are being built, however the last one wins because they will both output to the same path.

I've looked at building a universal app, but I don't think it's simple today with .NET, I've tried using lipo manually to combine the two outputs, but it's not just the hostapp process that needs to change between architectures, for now we might just need 2 separate artifacts.

KirillOsenkov commented 2 years ago

Hmm, do I need to build on Mac? I built on Windows and didn’t see any zip files. How do I obtain a zip file to publish to Releases?

slang25 commented 2 years ago

If you run the cake build script it will produce the macOS builds and zip them up, you don't need a mac to do it as the sdk will generate the apphost mac process that will bootstrap the app, the rest is all typical dotnet artifacts.

slang25 commented 2 years ago

What do you think about switching to GitHub Actions? I need to update how versioning works and select the appropriate artifacts: https://github.com/slang25/MSBuildStructuredLog/pull/1

slang25 commented 2 years ago

In that PR I'm building both architectures for mac

KirillOsenkov commented 2 years ago

Ah, OK, I haven't looked into the Cake bit at all yet. Yeah I suppose it's time to move to GitHub Actions.

jjmanton commented 2 years ago

@slang25 @KirillOsenkov Does a new release need to be triggered somehow? I am interested in the Mac artifacts as well, and see the PR above was merged.

KirillOsenkov commented 2 years ago

I'm not sure what I should do locally to produce the artifacts to publish to the release

slang25 commented 2 years ago

You can grab the macOS per-architecture builds from the CI artifacts here: https://ci.appveyor.com/project/KirillOsenkov/msbuildstructuredlog/builds/42050519/artifacts

I'm still interested in adding GitHub Actions as I think it would be easier to build on macOS/linux for the mac build, that way the user won't need to chmod +x the executable before it's usable.

There are a few outstanding things I'd need to solve/understand

The version number today is dictated by AppVeyor, if we wanted to move the build, or build on both CI platforms (I think that would be a good stepping-stone) then we might need to adopt something like GitVersion or MinVer
What's the integration process with SignPath, is that just for the Windows build, and what happens after the webhook is triggered? If it is Windows only then we can defer this while moving the macOS build to GitHub Actions.

KirillOsenkov commented 2 years ago

OK cool, I have uploaded both zips to the latest Release.

We should rename both zips to not have spaces, since GitHub Release replaces them with dots.