search

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.44k stars 190 forks source link

Differentiates items and item metadata nodes by colour #557

Closed drewnoakes closed 2 years ago

drewnoakes commented 2 years ago

Currently, in the dark theme at least, both items and their metadata have the same colour. Metadata items are prefixed with the work "Metadata", but it's not as easy to notice as a colour change.

My vote would be to make metadata notes a darker version that green, and leave the item colour alone.

What do people think? Would this be helpful?

Current

image

Darker metadata

This image shows the bits I'd change, and helps visualise that.

image

I'm not attached to the particular style used. Perhaps a new hue could be used for metadata. I just want to be able to distinguish item metadata nodes a bit more, and differentiate between property names and their values.

KirillOsenkov commented 2 years ago

I'd be OK with that. The dark theme looks OK, wanna pick something for light theme too?

KirillOsenkov commented 2 years ago

How about this:

image

KirillOsenkov commented 2 years ago

https://github.com/KirillOsenkov/MSBuildStructuredLog/commit/c31b7572c96f490cbb8b33a4f0116367b7b6b411

Dark theme:

image

drewnoakes commented 2 years ago

That looks great to me! Much easier to read. Thanks @KirillOsenkov.