NullReferenceException when loading binlog

[rolfbjarne]

Test case:

log-Build-20220202_162411.binlog.zip

Opening on macOS results in (latest Avalonia version as of today):

System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.Build.Logging.StructuredLogger.MessageProcessor.AddItems(IEnumerable items, TreeNode parent) in C:\projects\msbuildstructuredlog\src\StructuredLogger\Construction\MessageProcessor.cs:line 268
   at Microsoft.Build.Logging.StructuredLogger.MessageProcessor.ProcessTaskParameter(TaskParameterEventArgs args) in C:\projects\msbuildstructuredlog\src\StructuredLogger\Construction\MessageProcessor.cs:line 224
   at Microsoft.Build.Logging.StructuredLogger.MessageProcessor.Process(BuildMessageEventArgs args) in C:\projects\msbuildstructuredlog\src\StructuredLogger\Construction\MessageProcessor.cs:line 37
   at Microsoft.Build.Logging.StructuredLogger.Construction.MessageRaised(Object sender, BuildMessageEventArgs args) in C:\projects\msbuildstructuredlog\src\StructuredLogger\Construction\Construction.cs:line 417

Online results:

[KirillOsenkov]

Interesting, this is because in this case it logs a TaskParameterEventArgs with kind SkippedTargetOutputs and null ItemName and Items list:

Probably need to make a change to MSBuild to not log the event args in the first place.

For now I'll just add a null check in the viewer.

[KirillOsenkov]

Found a repro:

<Project>

  <ItemGroup>
    <_CodesignItems Include="foo" />
  </ItemGroup>

  <Target Name="Build"
          Inputs="@(_CodesignItems)"
          Outputs="@(_CodesignItems -> '%(CodesignStampFile)')">
  </Target>

</Project>

[KirillOsenkov]

Filed https://github.com/dotnet/msbuild/issues/7362

[KirillOsenkov]

I suspect you don't need me to republish the Windows viewer since you're using the Avalonia and the Live one. I'll include this fix with the next batch of fixes and updates.

[KirillOsenkov]

@rolfbjarne the CodesignStampFile metadata is missing on this item, not sure if intentional:

[rolfbjarne]

@KirillOsenkov thanks! I was eventually able to figure out that that was the problem, but it's certainly easier when the viewer works :)