KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.42k stars 188 forks source link

Compiler server messages showing up under Analyzer Summary node #587

Closed jaredpar closed 2 years ago

jaredpar commented 2 years ago

A few releases ago the C# / VB MSBuild task began outputting diagnostic messages for the compiler server. This was done to better enable detecting cases where the server was failing, restarting due to analyzer conflicts, etc ... Effectively make binlogs significantly more actionable for compiler developers.

Unfortunately these messages are showing up under the "Analyzer Summary" node which is unexpected.

MicrosoftTeams-image (1)

These messages all start with CompilerServer: and should be filtered away in CscTaskAnalyzer.

jaredpar commented 2 years ago

BTW: i'm planning on fixing this but wanted to file an issue vs. sending a PR without an issue.

KirillOsenkov commented 2 years ago

Cool, you probably want to look at this location somewhere: https://github.com/KirillOsenkov/MSBuildStructuredLog/blob/dab479efbaf581ae785e2f0158809b45be378193/src/StructuredLogger/Analyzers/CscTaskAnalyzer.cs#L17