Support for Extended Data

rokonec commented 10 months ago

Implementing: https://github.com/dotnet/msbuild/issues/9091

Context

MSBuild introduced new concept of Event args Extended data which are supposed to address need to extend events. One of its most appealing use cases is for passing extended compiler error and warning structured information into msbuild logging infrastructure. Having such info in binlog and viewer might be of use.

Changes Made

add support for extended data which will be introduced in FileFormatVersion 17
derived classes from Error, Warning, and Message including extended data
add context menu item which prints context of extended data to text window

rokonec commented 10 months ago

Attached is binary log for testing if needed. binlog.zip

KirillOsenkov commented 10 months ago

this is nice! I think if extended data is available, we should manufacture a message as a child node of the extended event, and put the full text in there. Also if extended metadata is present, add metadata child nodes for each metadata

KirillOsenkov commented 10 months ago

See Construction.AddProperties for an example, but maybe use Metadata instead of Property

KirillOsenkov / MSBuildStructuredLog