MSB4011 could be shown nested in the import tree

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.

MIT License

1.41k stars 188 forks source link

MSB4011 could be shown nested in the import tree #774

Open rainersigwald opened 2 months ago

rainersigwald commented 2 months ago

MSB4011.zip renders like this:

I think it would be helpful to have that warning under the associated file node, that is nest it under the "location" value of the warning rather than (or maybe in addition to?) the "evaluation warnings for this project" node.

Text log rendering shows this structure slightly better than the viewer today since it interleaves the warnings with the imports, showing their context.

KirillOsenkov commented 2 months ago

Sounds reasonable.

One could argue that it might be useful to have all the warnings bunched up together, but you could achieve that with $warning under(id:35) anyway (or "Search under node")