search

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.44k stars 193 forks source link

Analyzer / Generator summary doesn't display on non-English builds #795

Open jaredpar opened 1 month ago

jaredpar commented 1 month ago

The analyzer and generator summary nodes are created by looking for the following strings in a Message node in the binary log:

That marks the beginning of the summary output and the viewer will parse out the nodes below that. The problem is that those strings in the compiler are localizable strings. That means on non-English builds they will have different values. The strings in the viewer are hard coded. That means they won't match and the viewer won't produce summary nodes for analyzers or generators.

I'm not sure what the best way is to fix this. The compiler needs to emit localized messages here as it's part of the standard compiler output that is localized. There is no reasonable way for the viewer to match this across locale's.

Open to suggestions on how to best approach this problem.

KirillOsenkov commented 1 month ago

if you have a sample binlog, can you send it to me?