search

KirillOsenkov / MSBuildStructuredLog

A logger for MSBuild that records a structured representation of executed targets, tasks, property and item values.
MIT License
1.47k stars 198 forks source link

Switch to Centralized Package Management #798

Closed decriptor closed 3 months ago

decriptor commented 3 months ago

I'm not sure if this is a change you'd like in the project. For the most part this only moves the package versions to the Directory.Packages.props file. There was maybe one or two places where the packages versions differed slightly, and I picked the newer version.

I wasn't able to run the app locally with or without these changes because of a System.IndexOutOfRangeException being thrown when trying add generic.xaml to the MergedDictionaries:

public MainWindow()
{
    InitializeComponent();

    var uri = new Uri("StructuredLogViewer;component/themes/Generic.xaml", UriKind.Relative);
    var generic = new ResourceDictionary { Source = uri };
    Application.Current.Resources.MergedDictionaries.Add(generic);

This'll most likely cause problems with #782. Once that PR is in, I can fix this one.

KirillOsenkov commented 3 months ago

Thanks! Are you running on Mac or Windows? Note that StructuredLogViewer.csproj will only work on Windows with WPF, for Mac you want the Avalonia csproj.

KirillOsenkov commented 3 months ago

Apologies for creating merge conflicts, but the Avalonia PR is more valuable and a lot of hard work went into that, so I gave it priority.

Was there an issue that you thought Central Package Version Management will fix? Or is it just clean-up level?

Not sure what's going on with the IndexOutOfRange, that code is for loading the dark theme.

decriptor commented 3 months ago

No worries. The Avalonia PR definitely needed to go in first.

This is mostly cleanup, but it does help clean up package versions and better keeps them in sync. There were a couple out of sync.

I'm planning on throwing a few more PRs up that are probably more "general" maintenance to start.

I'll try and update the PR this evening.

decriptor commented 3 months ago

I'm testing this out on Windows and dark theme.

KirillOsenkov commented 3 months ago

Actually I took the liberty to resolve the conflicts already, I pushed to your branch, will make sure it works and merge. Thanks!

decriptor commented 3 months ago

Actually I took the liberty to resolve the conflicts already, I pushed to your branch, will make sure it works and merge. Thanks!

Thanks!

KirillOsenkov commented 3 months ago

FYi @decriptor https://github.com/dotnet/wpf/issues/9582

decriptor commented 3 months ago

Thanks! Good to know