App.config is not read when analyzing a folder of only dlls

bbronisz commented 7 hours ago

Hi,

I wanted to analyze Microsoft.Kiota.Serialization.Json.dll and its dependencies, with some redirects to see if they work correctly. But when I've put them in one folder and redirects in app.config it reported issues that should be handled by those redirects, as if they were not read. After debugging I've found that app.config is not taken into account but app.exe.config is OK. I think that command-line option to explicitly specify config file, or report that no config files were used or better documentation on how to name the config files would be helpful. Or use any *.config files, instead of only *.exe.config.

Thanks for the tool. Unfortunately it didn't helped me to find the cause of compatibility issue :), but I'll probably use it more often in future.

bbronisz commented 6 hours ago

It's maybe not totally related but might be: the tool reports dependencies from .NET 6: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\6.0.36\System.Text.Encodings.Web.dll .NET 8: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.11\System.Text.Encodings.Web.dll and .NET Framework GAC: C:\WINDOWS\Microsoft.NET\assembly\GAC_MSIL\System.Numerics\v4.0_4.0.0.0__b77a5c561934e089\System.Numerics.dll Could there be an option to specify framework? Or should it be read form app.config?

KirillOsenkov commented 3 hours ago

are all the dlls you're analyzing public? any chance you could zip the whole directory and upload here, along with the command line used?

app.config files aren't used at runtime, they are converted to yourapp.exe.config and the runtime looks for the exe.config next to the exe of the same name. You can manually specify your app.config as a separate argument on the command line and it will be checked.

bbronisz commented 2 hours ago

BinaryCompat.zip Simply: checkbinarycompat.

I know about app.config converting to app.exe.config but I was investigating a specific issue with incompatible dlls/assembly redirects which didn't have an executable that I could use. So I just copied the dlls to single folder + config to mimick the scenario where the issue happens to see what the tool would tell me.

What is the command line argument to specify my app.config? I've tried checkbinarycompat *.dll;app.config and checkbinarycompat -p:*.dll;*.config and some combinations but still don't see the app.config being used.

bbronisz commented 2 hours ago

I've found that the issue was caused by lack of assembly redirect for System.Text.Encodings.Web to version 8.0.0.0. Microsoft.Kiota.Serialization.Json.KiotaJsonSerializationContext.Default was throwing method not found for System.Text.Json.JsonEncodedText Encode(System.String, System.Text.Encodings.Web.JavaScriptEncoder). It was because the dll method had this signature:

static System.Text.Json.JsonEncodedText, System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 
    Encode(
        System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 value, 
        System.Text.Encodings.Web.JavaScriptEncoder, System.Text.Encodings.Web, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 encoder)

but Microsoft.Kiota.Serialization.Json was expecting this:

static System.Text.Json.JsonEncodedText, System.Text.Json, Version=8.0.0.5, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 
    Encode(
        System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089 value, 
        System.Text.Encodings.Web.JavaScriptEncoder, System.Text.Encodings.Web, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 encoder)

If checkbinarycompat would be able to detect such compatibility issues that would be great and amazing 😃.