KirixenYT / Gogoanime

Just a gogoanime streaming clone
http://gogoanimez.free.nf
28 stars 18 forks source link

What's the point of using php? #11

Open ArjixWasTaken opened 1 month ago

ArjixWasTaken commented 1 month ago

You are not actually using php, you only have it to split html in multiple files...

ArjixWasTaken commented 1 month ago

For example, this would be the perfect use of a for-loop in PHP

https://github.com/KirixenYT/Gogoanime/blob/main/anime-list.php#L69-L146

Sure, you do a for-loop for the actual content, but that is because it cannot be done in plain html https://github.com/KirixenYT/Gogoanime/blob/main/anime-list.php#L149-L161

Also, what the fuck is that php code

<?php
  $json = file_get_contents("$apiLink/animeList?page=$page");
  $json = json_decode($json, true);
  foreach($json as $animeList)  { 
?>

    <li title='<?php $desc = $animeList['liTitle']; echo htmlspecialchars($desc);?>'> <a href="/category/<?=$animeList['animeId']?>" title=""><?=$animeList['animeTitle']?></a></li>
<?php } ?>

you could make it easier to read you know

<?php

$json = file_get_contents("$apiLink/animeList?page=$page");
$json = json_decode($json, true);

foreach($json as $animeList)  { ?>
    <li title='<?= htmlspecialchars($animeList['liTitle']) ?>'>
        <a href="/category/<?= $animeList['animeId'] ?>" title=""><?= $animeList['animeTitle'] ?></a>
    </li> <?php
}
ArjixWasTaken commented 1 month ago

yeah ok I was being mean, sorry about that

ArjixWasTaken commented 1 month ago

But....I did notice that you are loading the actual analytics scripts from gogocdn... Did you just copy paste the html from the actual website?

ruriescaper commented 1 month ago

Nah, originally the whole script was unfinished from 2019 maybe, he's using it as a base....▪️

On Wed, 10 Jul, 2024, 4:16 pm Angelos Bouklis, @.***> wrote:

But....I did notice that you are loading the actual analytics scripts from gogocdn... Did you just copy paste the html from the actual website?

— Reply to this email directly, view it on GitHub https://github.com/KirixenYT/Gogoanime/issues/11#issuecomment-2220176599, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGNMNINMLGW6AZ6SPJ6JNALZLUGJFAVCNFSM6AAAAABKUT3BHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGE3TMNJZHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ArjixWasTaken commented 1 month ago

so this is a fork?

ruriescaper commented 1 month ago

maybe you can say that, but he actually made many changes to make it work ....

On Wed, 10 Jul, 2024, 4:21 pm Angelos Bouklis, @.***> wrote:

so this is a fork?

— Reply to this email directly, view it on GitHub https://github.com/KirixenYT/Gogoanime/issues/11#issuecomment-2220187489, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGNMNIMW7YLIQ3SHPDQXPB3ZLUG4PAVCNFSM6AAAAABKUT3BHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGE4DONBYHE . You are receiving this because you commented.Message ID: @.***>

KiriXen commented 1 month ago

But....I did notice that you are loading the actual analytics scripts from gogocdn... Did you just copy paste the html from the actual website?

As what @ruriescaper said, I've only updated the website to work properly, and yes it is using the cdn from the actual gogoanime website and I believe the code was also copied from the actual website but with majority updates.. and sorry for the late reply, My github account got locked and I lost the access to it and yeah this is the new account im gonna use from now on!