search

KirkMcDonald / kirkmcdonald.github.io

Simple web-based calculator for the game Factorio.
Apache License 2.0
540 stars 148 forks source link

Support of Space Exploration and beyond... #148

Open wladekb opened 5 years ago

wladekb commented 5 years ago

Hi Kirk,

I've been recently trying the Space Exploration mod and found out I cannot live without a calculator ;-)

Space Exploration requires a few other mods, and also has a complex system of recipes including the thermofluid loop where you need special factories that cool it down (with some losses) while it is then used to manufacture a lot of things and returned as "hot" thermofluid. Similiar loop issue is with space water and contaminated space water, biosludge and contaminated biosludge etc. Current solver doesn't handle that well. There are also a couple of changes required in "factorio-tools" to properly build the JSON data file on top of the mods lua code.

At this point I have some dirty fixes and proof-of-concept code for some of the isuses and a list of open challenges to solve.

  1. I think my first question is to ask if you're open to significant code contributions, and if so if you have any code style you would like me to stick with.
  2. For the bugfixes, is it fine for you to submit pull requests that solve multiple issue or you'd like to keep it one pull request for one bugfix?
  3. For the calculator code I would probably start with some refactor to start leveraging new JS features, but as you noted in #137 you have done some work in satisfactory-calculator, so I don't know if you have anything ready to commit or I would be free to do it myself?
  4. For the open challenges I'd be happy to discuss potential solutions in some quicker form than posting here, especially that some of them you've probably had a thought of eg. choosing the recipe to make given item and so on. Are you open to collaborate on this?
wladekb commented 5 years ago

@KirkMcDonald just in case you've missed it

webbugt commented 3 years ago

+1 on the issue, I can offer my services as well, I find your calculator an amazing and indispensable tool. Saves so much time tweaking ratios 😄