KirkMcDonald / kirkmcdonald.github.io

Simple web-based calculator for the game Factorio.
Apache License 2.0
553 stars 147 forks source link

added @ media print style to css #149

Open Ma124 opened 5 years ago

Ma124 commented 5 years ago

Before: before @ media print

After: (empty circles are shown when no modules are selected) image

mxdanger commented 5 years ago

Here are my implementations of it. Not finished yet but you can test it here.

White theme normally. Screen Shot 2019-06-03 at 7 20 01 PM

White theme while printing. Screen Shot 2019-06-03 at 7 18 06 PM

Default theme normally. Screen Shot 2019-06-03 at 7 21 41 PM

Default theme while printing. Screen Shot 2019-06-03 at 7 25 12 PM

Ma124 commented 5 years ago

@mxdanger shouldn't it be the white theme for printing automatically and you don't need the link icon in the print view, do you?

Ma124 commented 5 years ago

But I really like what you've done so far

mxdanger commented 5 years ago

@Ma124 I had to modify the JS so that the total power output touched the right edge so the table wouldn’t look weird. I might find a better way to do it later. Anyways, glad you found it nice.

mxdanger commented 5 years ago

It could be in white theme automatically but some people might want to a dark colored printout. Might as well give them a choice, but at the same time it might be good to have it be white automatically.