search

KirkMcDonald / kirkmcdonald.github.io

Simple web-based calculator for the game Factorio.
Apache License 2.0
553 stars 147 forks source link

Update 0.17 vanilla dataset to the latest version #172

Closed RustyBlade64 closed 5 years ago

RustyBlade64 commented 5 years ago

Closes #157, closes #171 and probably makes #170 obsolete.

Note: there is some issue with the new icons for ore not being scaled correctly in the spritesheet. This is only a minor visual issue, so I though it would be more valuable to get the updated recipes in first. I'll open a separate issue for that.

@KirkMcDonald I'll leave editing the changelog to you, so that the entry can have the (correct) date of the merge instead.

FoxLBA commented 5 years ago

I have fixed factoriodump which can scale icons. I can make a similar PR but not shure whether to add 17.59 dataset or not.

RustyBlade64 commented 5 years ago

I would argue that it should not stay there, mainly because there is no good point at which to remove it. Breaking changes are the thing you signed up for when selecting to play on the experimental branch. If someone wants to stay on old versions, they can always run the offline calculator :man_shrugging:. In any case, that is @KirkMcDonald 's call to make, so we will have to wait what he says.

@FoxLBA Definitely make a pull request for the icon scale fix (to factorio-tools I presume?). Otherwise someone else might spend time trying to fix it as well, would have been my next course of action :) Regarding updating/redoing this dataset PR, I'd say we should wait for feedback first.

KirkMcDonald commented 5 years ago

Obviated by b2d92eabedb786fadca71906f79808033bfa4a48. Thank for for this PR.