Bug: Furnace is not correctly loaded from URL

KirkMcDonald / kirkmcdonald.github.io

Simple web-based calculator for the game Factorio.

Apache License 2.0

547 stars 146 forks source link

Bug: Furnace is not correctly loaded from URL #60

Closed DarkMatterMatt closed 6 years ago

DarkMatterMatt commented 6 years ago

Reproduce by changing the furnace from electric to steel/stone then reloading webpage. The furnace icon will be a black box (because of line 156). The steel/stone furnace will not be used in any calculations (because of line 145).

Fix: settings.js, line 144 furnace = settings.furnace should be furnace = {name: settings.furnace} or (but I prefer the one above) the two furnace.names on lines 145 & 156 could be just furnace

KirkMcDonald commented 6 years ago

Fixed in 8330172f5f244d9248824a7f586b4c310f95aec8.