search

Kiro47 / MTU-Transfer-Course-Gatherer

I got tired of looking for classes to transfer in by hand, so here we are.
Mozilla Public License 2.0
4 stars 2 forks source link

Improvement/issues-29-31 #33

Closed Blu3spirits closed 4 years ago

Blu3spirits commented 4 years ago

May want to wait on this, until after @Kiro47 merges their PR #34 since it will change the csv file dropped.

Kiro47 commented 4 years ago

May want to wait on this, until after @Kiro47 merges their PR #34 since it will change the csv file dropped.

I can always just make this change on my branch if you end merging before I do, it's a small aspect.

Blu3spirits commented 4 years ago

Slimmed-down quite a lot with your guys' help!

course_gather                              latest              3a99e7ab9378        3 minutes ago       992MB
course_gather_dev                          latest              0ad64e380fc6        3 days ago          1.46GB

Course gather dev is before all of these optimizations.

Blu3spirits commented 4 years ago

I think github actions may have shit the bed again tonight. Going to ignore that failed run for now because I cannot reproduce that error on my local branch.

codetheweb commented 4 years ago

Yeah, I dunno what's going on. Tests pass locally. Same issue in https://github.com/Kiro47/MTU-Transfer-Course-Gatherer/pull/39.

Blu3spirits commented 4 years ago

Alright, thanks to @Kiro47 we're good now to merge this after I resolve the conflicts