KirovBvulgaru / google-cast-sdk

Automatically exported from code.google.com/p/google-cast-sdk
0 stars 0 forks source link

media_player.js MPEG-DASH doesn't support SegmentTemplate inside Representation #170

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The fix for issue #141 added support for MPDs that use SegmentTemplate 
elements, but it only seems to work if the SegmentTemplate elements are direct 
children of AdaptaionSet elements.  As described in ISO/IEC 23009-1 (the 
MPEG-DASH spec) section 5.3.9, a SegmentTemplate may be within a Representation 
element or inherited by the enclosing AdaptionSet or Period element.  This 
issue is about supporting SegmentTemplate elements within Representation 
elements.

I have attached a variation of the MPD provided with issue #141 that moves the 
SegmentTemplate elements down within each Representation element.

What steps will reproduce the problem?

Same steps as issue #141, except substitute the MPD attached to this issue.

What is the expected output?

Video playing.

What do you see instead?

Host object's onError is called with error code "1"; for example, the same 
cast-custom-receiver's onError handler logs the following to the console:

### HOST ERROR - Fatal Error: code = 1 sample_media_receiver.html:574
window.mediaHost.onError sample_media_receiver.html:574
xe media_player.js:2799
ve.ad media_player.js:2814
h.ad media_player.js:2838
h.Fe media_player.js:2969

(Line numbers correspond to media_player.js with Chrome debugger's 
pretty-printing enabled.)

Original issue reported on code.google.com by peter.jo...@qrclab.com on 25 Feb 2014 at 11:25

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by anad...@google.com on 26 Feb 2014 at 4:23

GoogleCodeExporter commented 8 years ago
Note that this structure, of SegmentTemplate inside Representation elements, is 
typical of SegmentTemplate MPDs produces by GPAC's MP4Box.

Original comment by peter.jo...@qrclab.com on 26 Feb 2014 at 5:16

GoogleCodeExporter commented 8 years ago
Thanks for your report! This will be fixed with the next media player library 
update.

Original comment by vadi...@google.com on 26 Feb 2014 at 11:09

GoogleCodeExporter commented 8 years ago
It seems like this bug is fixed in the currently available media_player.js 
(from 2014-03-05, md5:d505989d21027903ed77d0e6aafcbb14).  Thanks!

Original comment by peter.jo...@qrclab.com on 7 Mar 2014 at 11:07

GoogleCodeExporter commented 8 years ago
Yes, we have made an update that has addressed that, and a bunch of other 
fixes. I am working with our documentation team to provide a permanent place to 
put change lists and update info so developers can exactly see what has been 
fixed. I will close this issue as fixed, if you run into issues, please let us 
know.

Original comment by anad...@google.com on 7 Mar 2014 at 11:38