search

Kirpal / Keyboard-Layout-Editor-for-Blender

Allows you to import keyboard layouts into blender and render them in 3d
334 stars 38 forks source link

Sync the exception branch of the legend handling #33

Closed wilderjds closed 6 years ago

wilderjds commented 6 years ago

Some changes were made to the try: branch of the legend creation that were not ported to the exception branch. Copy them over.

This part of the code should really be refactored. What exception is the branch supposed to catch anyways?

Kirpal commented 6 years ago

Blender throws an exception when the Unicode character isn't found in the font. So if the font doesn't include that character or a placeholder "box" blender throws an error and the script defaults to a font with really good unicode support

wilderjds commented 6 years ago

And where is the exception thrown? Do we really need to wrap that much? All the shrink-wrapping thing could go outside of it I guess

On April 1, 2018 9:33:03 AM EDT, Kirpal Demian notifications@github.com wrote:

Blender throws an exception when the Unicode character isn't found in the font. So if the font doesn't include that character or a placeholder "box" blender throws an error and the script defaults to a font with really good unicode support

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Kirpal/Keyboard-Layout-Editor-for-Blender/pull/33#issuecomment-377787188

Kirpal commented 6 years ago

I can't really look over the code right now because mobile chrome crashes when I open that file, but iirc i only put what needed to be in there. But you're probably right about the shrinkwrapping, probably some other stuff could be taken out too. I'd like to make it overall more elegant.

(Should be able to get a new laptop soon)

On Mon, Apr 2, 2018, 11:00 AM Jacopo De Simoi notifications@github.com wrote:

And where is the exception thrown? Do we really need to wrap that much? All the shrink-wrapping thing could go outside of it I guess

On April 1, 2018 9:33:03 AM EDT, Kirpal Demian notifications@github.com wrote:

Blender throws an exception when the Unicode character isn't found in the font. So if the font doesn't include that character or a placeholder "box" blender throws an error and the script defaults to a font with really good unicode support

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub:

https://github.com/Kirpal/Keyboard-Layout-Editor-for-Blender/pull/33#issuecomment-377787188

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Kirpal/Keyboard-Layout-Editor-for-Blender/pull/33#issuecomment-377948711, or mute the thread https://github.com/notifications/unsubscribe-auth/ARiF8_DMvrB55f1x_FkiQOkXLOALXpD_ks5tkjzxgaJpZM4TCs_u .