search

KirstieJane / STEMMRoleModels

Inspire future generations by providing the most exciting and diverse speakers for your conference.
http://www.stemmrolemodels.com
MIT License
280 stars 150 forks source link

Nav bar doesn't work on mobile #106

Closed KirstieJane closed 8 years ago

KirstieJane commented 8 years ago

So saaaad!

I can see the nav-bar but when I click on it it doesn't show me anything.

If anyone knows why please comment!

Ryuno-Ki commented 8 years ago

The JavaScript isn't loaded.

Open the developer tools of your web browser and look at the Network pane. For Firefox, it is explained on MDN.

Ryuno-Ki commented 8 years ago

I checked with Web IDE as well (you need to download an ISO and then hit the browser app on the left side to get access to Developer Tools there). screenshot_stemmrolemodels320x533px

The image is too big. Related to #98?

Ryuno-Ki commented 8 years ago

Concerning WebIDE.

My battery runs dry in a few minutes.

geminiimatt commented 8 years ago

i am taking a look at this as well. more soon.

amitkumarj441 commented 8 years ago

@KirstieJane Did you import the jQuery before importing bootstrap, out of order it won't work! For ex: `

`
KirstieJane commented 8 years ago

Hi @geminiimatt - thank you for taking this on - I'm going to assign you to this issue! [EDIT: wait - no I'm not because you aren't a contributor. Ok, you're virtually assigned :wink:] Very likely @amitkumarj441 and @Ryuno-Ki's comments will be helpful!

@Ryuno-Ki - the fact that the image is too big is a different issue!! It needs to be fixed too. If you have time and feel like it you could open a new issue to describe the problem!

Thank you all for your help :smile:

amitkumarj441 commented 8 years ago

Hey @KirstieJane ,

I hope you checked my comment on this issue, well I'll soon fix this issue by adding the navbar switching part in js file. Let me assign this issue, I'm going to fix this bug.

Cheers, Amit Kumar Jaiswal

Ryuno-Ki commented 8 years ago

Hey, @KirstieJane,

sadly I'm overloaded with work at the moment. But I'm still watching this repo and chime in, whenever I can help.

stain88 commented 8 years ago

Hey @KirstieJane,

It looks like none of the pages source bootstrap js, and only the search_database page has jquery. I've added a cdn link to all the pages, and the dropdown now works, although the first couple of links sit next to the logo. Would it be worth having this as a navbar-brand class and moving it out of the collapse, so that it is always visible?

E I also did a bit of html-linting while in the files, there were a few instances of improperly closed tags, mis-matching tags

Ryuno-Ki commented 8 years ago

CDNs are fine. Until they got down (b/c of a DDoS, for example).

We should look after adding some decent styles in a <noscript> to keep the site usable.

KirstieJane commented 8 years ago

Thanks @stain88! I've merged your changes! And now the navbar works! Great!

BUT - I agree that it shouldn't have the logo on the inside of the collapse. Any pull requests on that front are very welcome :smile:

stain88 commented 8 years ago

Cool, I'll work on that tomorrow

KirstieJane commented 8 years ago

@Ryuno-Ki I don't think DDoS happen often enough for a no script version to be of high priority. But if you or anyone else wanted to work on it then that's fine.

stain88 commented 8 years ago

Problem is, I was silently laughing at that too, but then that whole DynDNS DDOS happened and took down Twitter, Github, Reddit, and others, so I'll put it in locally with the nav bar changes.