search

KishorJena / react-native-whatsapp-stickers-animated

Other
4 stars 1 forks source link

Animated Stickers #1

Open vitorhenrique123 opened 1 year ago

vitorhenrique123 commented 1 year ago

Environment

System: OS: Linux 5.10 Manjaro Linux CPU: (12) x64 AMD Ryzen 5 5600X 6-Core Processor Memory: 651.52 MB / 15.61 GB Shell: 5.9 - /usr/bin/zsh Binaries: Node: 18.3.0 - /usr/bin/node Yarn: 1.22.17 - /usr/bin/yarn npm: 8.1.4 - /usr/local/bin/npm Watchman: Not Found SDKs: Android SDK: 31 IDEs: Android Studio: Not Found Languages: Java: 1.8.0_332 - /usr/bin/javac npmPackages: @react-native-community/cli: Not Found react: 18.0.0 => 18.0.0 react-native: 0.69.1 => 0.69.1 npmGlobalPackages: react-native: Not Found

Describtion

@CrackerKSR Is support for animated stickers currently working correctly? I'm trying to do some tests and unfortunately, it doesn't work when the animated_sticker_pack option is true. Also - debugging the DownloadImageAnimated module, but it seems incomplete. I didn't understand correctly how the animated stickers work. image This only happens with animated stickers. Statics work very well - great job, by the way.

Reproducible Demo

JS let pack = { "identifier": "animatedstickerstest", "name": "StickersAnimated", "publisher": "VitorTeste", "tray_image_file": "https://vitorhenrique.me/STK-20220705-WA0020.webp", "publisher_email": "contact@myproject.com", "publisher_website": "https://myproject.com", "privacy_policy_website": "https://myproject.com/legal", "license_agreement_website": "https://myproject.com/license", "animated_sticker_pack" : true, "avoid_cache" : true, "image_data_version": "1", "stickers": [ { "image_file": "https://vitorhenrique.me/STK-20220705-WA0020.webp", "emojis": ["✌️"] }, { "image_file": "https://vitorhenrique.me/STK-20220705-WA0020.webp", "emojis": ["😍","😻"] }, { "image_file": "https://vitorhenrique.me/STK-20220705-WA0020.webp", "emojis": ["😎"] } ] }

KishorJena commented 1 year ago

It should work with local images. it won't work for animated sticker as I had removed those codes which downloads image from url.

vitorhenrique123 commented 1 year ago

Do you have any clue why it only works for local files?

It should work with local images. it won't work for animated sticker as I had removed those codes which downloads image from url.

KishorJena commented 1 year ago

Do you have any clue why it only works for local files?

It should work with local images. it won't work for animated sticker as I had removed those codes which downloads image from url.

first of all your image is not meeting with requirements. I have tried with url t was working with proper image files. But later I had made many changes and I am not sure if Downloading image code is changed or not due to time gap.

I will fix it soon. There is another issue there adding 2 new sticker pack make changes in current pack. I fixed that too but did not push. I may create new repo after finalising. I have added useful methods like resizing both animated and static images as per the requirements by whatsapp. Currently I am trying to make stickerpack editable. Means even after adding sticker to whatsapp user can add more stickers to exisintg pack or remove any sticker.

KishorJena commented 1 year ago

Do you have any clue why it only works for local files?

It should work with local images. it won't work for animated sticker as I had removed those codes which downloads image from url.

Okay I was working with same file today and found that I had removed URL(sUrl).openStream() for Animated. So it should download the static image files for now but now animated files.

KishorJena commented 1 month ago

try react-native-whatsapp-stickers-manager