search

Kismon / kismon

A GUI client for kismet
BSD 3-Clause "New" or "Revised" License
106 stars 20 forks source link

New feature - Cache map tiles #7

Closed krzotr closed 5 years ago

krzotr commented 8 years ago

Hi,

I created feature 'Cache map tiles'. Option is very usefull if you do not have internet access. In simple way you can pre-download map (pre caching). Feature is located in 'View -> Cache map tiles'.

By the way, i removed warnings:

/kismon/windows/channel.py:1: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded. from gi.repository import Gtk /kismon/kismon/core.py:55: PyGIWarning: OsmGpsMap was imported without specifying a version first. Use gi.require_version('OsmGpsMap', '1.0') before import to ensure that the right version gets loaded.

Thank you

dreadnought commented 8 years ago

Hi, I have some concerns about that. I want to avoid that we get blocked by one of the map providers, with the result that all users would see a blank map (again).

First of all we have to respect the OpenStreetMap Tile usage policy: https://wiki.openstreetmap.org/wiki/Tile_Usage_Policy

        cache_map_tiles_menuitem = Gtk.MenuItem.new_with_mnemonic('Cache map tiles')

I think that it will be unclear for other people what happens when they click on it. The normal caching is enabled by default, but here happens something different.

            zoom_start=self.map.osm.get_property('zoom'),
            zoom_end=int(self.config["map"]["custom_source_max"])

Nobody except us will know that these values are used, they should be displayed before the download starts. It should be avoided that someone zooms to level 1, clicks the button and starts downloading the world.

Please think about it.

Best regards, Patrick