search

KissPeter / APIFuzzer

Fuzz test your application using your OpenAPI or Swagger API definition without coding
GNU General Public License v3.0
416 stars 65 forks source link

Report filenames start with -1 #52

Closed martinburchell closed 2 years ago

martinburchell commented 2 years ago

Describe the bug

The reports that get stored in the directory indicated by the --report_dir argument have filenames prefixed with the current_index on the model. current_index seems to start with -1 (a feature of kittyfuzzer?) so the first report is -1-something, the next 0-something and then 1-something. It would make more sense to me for the reports to begin with either 1 or 0. In addition, zero padding the filenames would make sorting by name consistent with the order in which the reports were created.

Related API definition

I assume any, but here's the one I was using

api_schema.yaml.txt

Software environment (please complete the following information):

KissPeter commented 2 years ago

Hi,

Can you check https://github.com/KissPeter/APIFuzzer/tree/report_filename_improvement ? Any PR is welcome Péter

martinburchell commented 2 years ago

Hi,

Can you check https://github.com/KissPeter/APIFuzzer/tree/report_filename_improvement ? Any PR is welcome Péter

Yes that looks good. I wasn't sure if current_index should start at -1 but that's down to kittyfuzzer.

PeterKiss-Sophos commented 2 years ago

Yes it is Kitty stuff. I'm closing this ticket and this change will be in the next release. In the meantime you can get in from master