List item deleted when changing depth

Kit / slate-plugins

A collection of plugins for SlateJS, maintained by ConvertKit

https://convertkit-slate-plugins.netlify.com/

MIT License

52 stars 22 forks source link

List item deleted when changing depth #22

Closed adjourn closed 5 years ago

adjourn commented 5 years ago

How to reproduce:

Go to list docs
Drop caret into either Subitem 2 or Item 2
If Item 2, increasing depth deletes the item
If Subitem 2, decrease depth and if then increased, item gets deleted

It also seems that if you repeat Subitem 2 steps for middle list item in a sub-list that has more than 2 items, all list items after that one get deleted after depth increase. Don't remember seeing this bug before.

Ubuntu, Chromium (can't test it on other platforms at the moment)

brendancarney commented 5 years ago

Thanks for the issue @adjourn! I have also confirmed it (OSX Chrome) and am looking into it.

brendancarney commented 5 years ago

Ok, I have a PR (#23) out for it. Let me know if you see any issues. Thanks again!

adjourn commented 5 years ago

Looks good but Im unable to test it because I have no idea how to add a package based on pull request with yarn and monorepo. Thanks for the quick PR though.

You might want to consider postpone publishing right after this PR, I've discovered that Backspace and Delete have very different behaviors (Delete is off) and I don't think it's how you meant it to be.

I'll open another issue for that.

brendancarney commented 5 years ago

I'll have to look into how you can do that, I'm not sure either. I always have the repo locally so I yarn link. For some reason the deploy preview isn't working for this PR either.

And thanks! I'll look into the other issue when you create it.