search

Kit / slate-plugins

A collection of plugins for SlateJS, maintained by ConvertKit
https://convertkit-slate-plugins.netlify.com/
MIT License
52 stars 22 forks source link

Missing schema normalizations in slate-lists #34

Closed alanct-minted closed 5 years ago

alanct-minted commented 5 years ago

I think there might be some missing normalization rules for slate-lists, but haven't had the time to dig into all of it yet. I know at the very least that by highlighting list items and dragging around, I can get my editor into weird states where list-item-child blocks don't have child text nodes.

Screenshot from 2019-05-09 10-05-45 Screenshot from 2019-05-09 10-06-25

Not sure what others are missing/leading to three bullets showing on the same line. A little gif tinkering with the documentation example for a couple seconds. The flash to white at the end is actually the page crashing with the exception below.

Peek 2019-05-09 10-10 Screenshot from 2019-05-09 10-11-49

brendancarney commented 5 years ago

This should be fixed by https://github.com/ConvertKit/slate-plugins/pull/54. If not, feel free to reopen. Thanks!