search

Kitsumon / breeding-testnet

Breeding testing issues/bugs
2 stars 0 forks source link

Search only searches first element not both #44

Closed Mistbind closed 2 years ago

Mistbind commented 2 years ago

Prerequisites

Issue tracker is ONLY used for reporting bugs. Use stackoverflow for supporting issues.

For more information, see the CONTRIBUTING guide....

Features:

Please note by far the quickest way to get a new feature is to file a Pull Request.

We will consider your request but it may be closed if it's something we're not actively planning to work on.

Bug reports: search feature not working

Expected Behavior

To show results of both elements or a kitsu

Current Behavior

Shows only results for first elements not second element example kistune is Fire/Mana when use search on Mana Kitsune does not show, but she will show on fire search

Also no results for potions show up

Possible Solution

Have search show results for both elements rather then only the first

Steps to Reproduce

  1. Go to search feature click an element Screenshot_20220527-171108_MetaMask Screenshot_20220527-171157_MetaMask Screenshot_20220527-171237_MetaMask Screenshot_20220527-171248_MetaMask Screenshot_20220527-171316_MetaMask

Context (Environment)

Detailed Description

Possible Implementation

JayArrowz commented 2 years ago

how this was intended to work is your first selection will filter primary type the second selection will filter secondary type.

.e.g. lets say you selected Air then Water The filter will be searching for Primary Air and Secondary Water.

If you deselect Air it'll search Primary water

If anyone has ideas on UI improvements to this we can raise a feature ticket

JayArrowz commented 2 years ago

Marked potions as a bug... Low priority as i guess a user can de-select the attribute filters then they'd be able to view the potions?

Mistbind commented 2 years ago

I see I had expected both elements to be 'equal' not hierarchy of one and two, in use trying to breed for affinity I expected anything with Mana as a base element to show up when i clicked Mana. Sorry that it's the second report I put in that were evidently intended as features.

On Thu, Jun 2, 2022, 7:10 PM JayArrowz @.***> wrote:

Marked potions as a bug

— Reply to this email directly, view it on GitHub https://github.com/Kitsumon/breeding-testnet/issues/44#issuecomment-1145461170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZILPDN7B6RJ44SOVVHOZKTVNFENVANCNFSM5XFTLBNQ . You are receiving this because you authored the thread.Message ID: @.***>

JayArrowz commented 2 years ago

Fixed - new search system has been added