Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
232 stars 96 forks source link

Screen Reader compatibility, for visually impaired accessibility #1124

Open Kitteh6660 opened 6 years ago

Kitteh6660 commented 6 years ago

image

jfmherokiller commented 6 years ago

well from a cursory glance at https://www.sitepoint.com/accessibility-in-flex-apps/ it seems you must edit the .actionScriptProperties file and change generateAccessible=”false” to generateAccessible=”true”.

Then make sure that the buttons/ui elements are either subclasses of or copies of the ones listed here https://help.adobe.com/en_US/flex/using/WS2db454920e96a9e51e63e3d11c0bf69084-7da6.html .

melch-i commented 6 years ago

git

jfmherokiller commented 6 years ago

well based on the description provided "the controls are announced as button" my best guess is that the software is not reading the label text on the button.

It is instead reading some other attribute of the button.

darkempathy commented 6 years ago

Hi.

Tracked down this page to comment. The problem I believe is flash specific, usually screen readers will be fine reading the alt attributes of most controls, but in the case of flash it just seems to read the control type, even when I use shortcuts to specifically read additional information about the focused control. I would be interested to know what modifications have been made to the interface of CoC revamp as opposed to original CoC, since in original CoC the controls are not read as buttons but just as areas of text which can then be clicked on, similar to hotspots in a webpage.

if you want more specific info, (from people with more technical knolidge than I have), feel free to ask on the forums over at www.audiogames.net,

The topic concerning CoC (both the original game and Revamp mod), can be found here: http://forum.audiogames.net/viewtopic.php?id=23840

hth. Since this is the same problem which occurs with Trials in tainted space, it'd be great if it could please be sorted out.

jfmherokiller commented 6 years ago

well the code for the interface is stored in lib/fla/MainView.fla if you wish to fix the issue your best guess would be to look at that file.

On a side note I am looking into converting that file into mxml so that it can be compiled with apache flex.

Stadler76 commented 6 years ago

@jfmherokiller IIRC MainView.fla is already fully converted to MainView.as [Edit:] Yep, MainView.fla can be safely removed from the codebase.

jfmherokiller commented 6 years ago

@Stadler76 Sorry but i tried removing it and replacing all the classes it provides with raw source code versions i found here http://www.libspark.org/svn/mxp/specialbutton/as3/src/v0.85/ but it had a lot of errors involving the combo box used by the preset character drop down menu.

[Fault] exception, information=TypeError: Error #1009: Cannot access a property or method of a null object reference.

at fl.controls::BaseButton/drawLayout()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/controls/BaseButton.as:552]
at fl.controls::BaseButton/draw()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/controls/BaseButton.as:521]
at fl.core::UIComponent/drawNow()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/core/UIComponent.as:1198]
at fl.controls::ComboBox/drawLayout()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/controls/ComboBox.as:1500]
at fl.controls::ComboBox/draw()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/controls/ComboBox.as:1421]
at fl.core::UIComponent/callLaterDispatcher()[/<user>/Documents/gitdir/Corruption-of-Champions-Mod/classes/fl/core/UIComponent.as:1379]
Stadler76 commented 6 years ago

MainView.as is here: https://github.com/Kitteh6660/Corruption-of-Champions-Mod/blob/master/classes/coc/view/MainView.as Could you tell me, why you're adding yet another folder for GUI components? Did you just miss classes/coc/view?

jfmherokiller commented 6 years ago

well @Stadler76 i tried deleting MainView.swc just now and it wont compile under apache flex or adobe flex without those extra classes. What are you using to compile the game?

Stadler76 commented 6 years ago

Aah, ok

jfmherokiller commented 6 years ago

Btw the reason for the above error is because the control is unable to find its "skins"

jfmherokiller commented 6 years ago

@Stadler76 made a pull request which completely removes the MainView.swc dependency here #1148

Stadler76 commented 6 years ago

Neat. Those pesky binaries have to die.

meero619 commented 6 years ago

Hey there. I tried downloading the latest release. but even with the latest release the game is still inaccessible. I really hope you find out the reason why it's not accessible and try to fix it, cause I really love the stuff you added to the mod and just from reading about it? I'd totally love to try it out. all the best :), thanks and keep up the excellent work

darkempathy commented 6 years ago

Hello.

Okay this is rather confusing. I was alerted by someone on audiogames.net to the fact that certain versions of the revamp mod actually do work with screen readers. Sadly the latest 4.13 isn't one of them, but the vanilla version 4 and indeed version 4.8 seemed to work fine, after that the versions have the labelling issue I previously mentioned. Whether this is due to enhancements with screen reading programs or changes in the mod we're not sure.

So first question, is Vanilla version 4 essentially just the standard CoC from fenoxo's site but with a tweak or two? Second any idea why versions later than 9 had the labelling problem where all choices are just read as "button" rather than having the text on their labels read correctly?

I apologize if this is a really stupid question or if I missed something somewhere in how Github's numbering of releases works, however some explanation would be helpful, especially if (as I ferbently hope), this issue can be fixed to make a fully screen reader friendly and uptodate version of the CoC mod new weapon enhancing and all the other fun stuff that has been added. Thanks in advance,

Dark,

admin www.audiogames.net