Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
232 stars 97 forks source link

[Development] Sonarqube default quality profile has changed #1316

Open brrritssocold opened 6 years ago

brrritssocold commented 6 years ago

The default quality profile for Flex has been updated ("Sonar way"). This deactivated some rules, resulting in a lot less issues getting reported.

This could be an opportunity to create a Quality profile for CoC that matches the Coding guidelines.

Thoughts?

Stadler76 commented 6 years ago

The default quality profile for Flex has been updated ("Sonar way"). This deactivated some rules, resulting in a lot less issues getting reported.

Could you be more specific about what has actually been changed?

This could be an opportunity to create a Quality profile for CoC that matches the Coding guidelines.

Thoughts?

Sounds good, but we shouldn't enforce all parts of the guideline since I see that more as a recommendation for better readability and more consistent code style and less as a must do.

To get to the point: I think setting a soft cap and a hard cap for line length could be a good start, if that is possible.

brrritssocold commented 6 years ago

Could you be more specific about what has actually been changed?

Sure. I cannot find a change log for the default quality profiles (very annoying), so from memory these rules were deactivated:

Source: current quality profile

To get to the point: I think setting a soft cap and a hard cap for line length could be a good start, if that is possible.

I did a quick search, it is does not seem possible to add or modify rules in the 'Community edition' of Sonarqube / Sonarcloud.