Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
230 stars 97 forks source link

[Enhancement] Perk Toggling During Ascension #1386

Open AnonymousIncognito5 opened 5 years ago

AnonymousIncognito5 commented 5 years ago

Please prefix the title with the issue type: [Bug], [Enhancement], [Question], [Other]

I have checked the following before submitting this issue:

Overview

Many perks in the game work at cross-purposes: Fertility+ and Fertility-, for example. In the interest of trying out alternative play-styles without permanent ramifications, I think it would be helpful to allow toggling perks on or off during ascension. To be clear, this would not give any perk points or ascension points back, unlike the respec option, and you would not need to meet stat requirements (like minimum Corruption) to re-enable them while ascending later. You could instead allow perk toggling at any time, though I feel that would be much more likely to cause balance and stability issues.

Obviously, this would only be allowed for perks that persist between ascensions in the first place: perks from levelling up, permed perks, and history perks. You should also be able to regain perks normally (level-up perks aside, since that would waste perk points).

I've looked over the relevant code a bit, and I don't think that disabling perks at that point could break anything. You'd have to track disabled perks, of course, and make sure they aren't listed as options when levelling up. Code should be added to the perk adding function to simply re-enable a disabled perk rather than inserting a new one, and the perk finding function should be changed to ignore disabled perks.

Optionally, you could have any perk that is dependent on a disabled perk (like Acclimation and Corrupted Libido) also be disabled.