Serialize item storage - Githubissues

Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660

233 stars 98 forks source link

Serialize item storage #1406

Closed brrritssocold closed 5 years ago

brrritssocold commented 5 years ago

Use serialization for items stored in the PC's inventory.

ItemSlot is now serializable
Moved item slots to Inventory
Cleaned up itemSlot save / load code
Added some documentation to Inventory

brrritssocold commented 5 years ago

Hmm this is interesting, debug build completes without issues on local machines. I will look into it.

Stadler76 commented 5 years ago

2019-01-21 04_59_17-unit test results This test seems to always fail. At least in the debug build.

brrritssocold commented 5 years ago

Yeah, I'm trying to see if I can reproduce the issue with a debugger attached. If that is not possible, adding logging code to figure out what is going on.

Been busy the past few days, so have not gotten round to it yet.

Stadler76 commented 5 years ago

Ok, I reran the whole build just now and only the debug job fails. The release job finishes without errors. Kinda weird ...

brrritssocold commented 5 years ago

Update to player 31 did not help either (build-dep)

brrritssocold commented 5 years ago

Found the issue, preparing patch and investigating further why release build works and debug does not (although I already have a possible cause).

brrritssocold commented 5 years ago

While the Serialization Util threw an Error, it was caught and a GUI error printed. The failure was detected only during loading, because data was missing.

As to why release works, possibly a race condition with the save file or something similar (if each test uses a new save file, test+UUID in my test case, release also fails).