Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
228 stars 97 forks source link

[Bug] Issue with loading save in 1.4.16 (Serialization issues) #1417

Closed Kitteh6660 closed 5 years ago

Kitteh6660 commented 5 years ago

Please prefix the title with the issue type: [Bug], [Enhancement], [Question], [Other]

I have checked the following before submitting this issue:

Overview

The game crashes and throws an error. Some saves no longer work because of that.

Game version

1.4.16

Expected behaviour

The game should load and take you to camp.

Actual behaviour

The game throws an error and the save is corrupted. ArgumentError: Serialized Vector cannot be null at classes.internals::SerializationUtils$/deserializeVector()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\internals\SerializationUtils.as:61] at classes::Player/deserialize()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\Player.as:3754] at classes.internals::SerializationUtils$/deserialize()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\internals\SerializationUtils.as:163] at classes::Saves/deserialize()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\Saves.as:2471] at classes.internals::SerializationUtils$/deserialize()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\internals\SerializationUtils.as:163] at classes::Saves/loadGameObject()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\Saves.as:1355] at classes::Saves/loadGame()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\Saves.as:583] at Function/<anonymous>()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\classes\Saves.as:267] at Function/<anonymous>()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\includes\engineCore.as:109] at coc.view::CoCButton/click()[C:\Users\Cathy Trepasso\Documents\Corruption_of_Champions\Corruption-of-Champions-Mod\classes\coc\view\CoCButton.as:109]

How often can this be reproduced?

It has something to do with certain saves and it might be the serialization changes.

Steps to reproduce the issue

  1. Download the save file.
  2. Go to Data then Open File.
  3. Select the save file. It will crash. I was told it would work in 1.4.15 but not 1.4.16.

If possible, attach a save file that reproduces the issue. New_Version.txt

Kitteh6660 commented 5 years ago

I've managed to get a workaround done and legacy inventory should now load.