Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
228 stars 97 forks source link

[Bug] Aiko 1st Meeting, Player Type Detection Issue #1450

Open mangaman9000 opened 4 years ago

mangaman9000 commented 4 years ago

I have checked the following before submitting this issue:

Overview

I started the game with the latest release and the history of Hikari. I have since changed to a Tigershark look and do not have any traits related to Kitsune. When I first meet Aiko (on day 174), the text suggest that the system thinks I am a Kitsune. Based on the code for Aiko first meeting, there is something that has flipped the kitsuneScore to be not 0. I have edited the save file, but I have not changed anything that related to kitsuneScore.

Game version

1.4.17c Playing in Flash Player 18 on local system

Expected behaviour

Since my character is not a Kitsune, the kitsuneScore flag should be 0 and I should get the "trespassing in kitsune territory" response instead of a Kitsune response.

Actual behaviour

Aiko is acting like I am a Kitsune. My character is a Tigershark with a tail fin, not a Fox tail. The code suggest that the kitsuneScore flag is not 0, which assumes the character is a Kitsune (the other options being having 9 Kitsune tails).

How often can this be reproduced?

Unsure. I have only ran into this one time with the version I am on. Since it is the initial meeting, it is hard to reproduce from a restart.

Steps to reproduce the issue

I do not have steps to reproduce this as I am not sure if some minor various in how I played everything or met people would cause the flag to be flipped. It is possible it might have been flipped from the start with the pre-defined character (which is described "as a herm with a super-thick cat-cock, D-cup breasts, and out-of-this-world armor, you’re a natural pick for champion."). I have ran into all three of the Kitsune girls, but have not joined them (either fighting or leaving). I have not used the items they have given me. Below is what the stats shown for Racial Scores and some info from looking around:

Racial Scores Human Score: 5 Mutant Score: 5 Shark Score: 5 Horse Score: 1

As for why it thinks I am a Kitsune, the kitsuneScore function may allow the return to be negative (based on looking at the code). Since the Aiko function checks for kitsuneScore to be 0, that one is false and the else is to assume the player is a Kitsune (Lines 83 - 107 in AikoScene.as for the text selection and Lines 1567 - 1617 in Player.as for kitsuneScore). I am having trouble finding hasScales, hasGooSkin, and vaginalCapacity functions to confirm this or see if there is a miss trigger. One of those could cause the score to be greater then or less then 0. Those are my thoughts at least.

linklight2 commented 4 years ago

I actually encountered this in-game; Aiko thought I was a 9 tails when I encountered her at first, as a human. I didn't think much about it at the time, but seeing this bug reminded me