Kitteh6660 / Corruption-of-Champions-Mod

CoC source from fenoxo, modded by Kitteh6660
233 stars 98 forks source link

How to contribute? #347

Closed jackdarker closed 6 years ago

jackdarker commented 8 years ago

Hi,

I played COC ever since but now started to mod it because I have the feeling of missing a "normal" male-wolf character.

Whats the plan:

I would like to ask if you could merge this into your git before I start modding even more existing code. (https://github.com/jackdarker/Corruption-of-Champions-Mod) I didnt contribute with git until now, so I dont know how exactly contribution works, should I create a pull request? A big portion of the code isnt tested so far, but I would like some backfeed (for coding style, embeding in old code) before continuing work on it. And I had to touch some code I didnt want to ,so I dont know if you would accept this complex pull request. I'm not a writer and english isnt my native tongue, so I could use some help with storytelling and spellchecking. I'm more the programer-type but didnt do anything fancy in AS so far.

Done so far:

Kind regards JD

Kitteh6660 commented 7 years ago

If you want but try to make sure everything works properly. You should change bound back and use existing status effects unless necessary.

jackdarker commented 7 years ago

There is no existing bound-status effect that I could reuse without getting weird textual output. F.e. the original Bound has hardcoded in Combat.as description "The feel of tight leather completely immobilizing .." and code if (player.findStatusEffect(StatusEffects.Bound) >= 0) { addButton(0, "Struggle", (monster as Ceraph).ceraphBindingStruggle);... That doesnt make much sense in all situations so I tried to separate description and combat logic.

Kitteh6660 commented 7 years ago

You can add a check if the opponent is Ceraph and put different texts.

jackdarker commented 7 years ago

You mean in Combat.as combatMenu(..) create some switch case inside this? if (player.findStatusEffect(StatusEffects.Bound) >= 0) { addButton(0, "Struggle", (monster as Ceraph).ceraphBindingStruggle); addButton(1, "Wait", (monster as Ceraph).ceraphBoundWait); }

Kitteh6660 commented 7 years ago

Yes, you can.

Kitteh6660 commented 6 years ago

No new responses and this is not an issue so it's now closed.