Kitteh6660 / DramaticDoors

Minecraft Mod for Forge & Fabric: 3-block high doors, in every vanilla variety! End enderman discrimination!
MIT License
6 stars 7 forks source link

[REQUEST] Compatibility with Thingamajigs' LockableDoor functionality #83

Closed adozenlionsroaring closed 4 months ago

adozenlionsroaring commented 4 months ago

Currently, Dramatic Doors is incompatible with the mod Thingamajigs (causes exit code -1, and disabling waterlogging doesn't help). The mod owner of Thingamajigs has determined that the incompatibility is specifically due to this mixin conflicting with Thingamajig's LockableDoor functionality (see discussion here):

https://github.com/Kitteh6660/DramaticDoors/blob/1.20.1-quifabrge/forge/src/main/java/com/fizzware/dramaticdoors/forge/mixin/DoorBlockMixin.java

Is there any possibility of a patch to allow the two to work alongside each other? No worries if not, I just thought I'd bring it up as a suggestion! :)

Kitteh6660 commented 4 months ago

I will possibly look into it! Thanks for bringing it up!

What version of Dramatic Doors are you using?

adozenlionsroaring commented 4 months ago

Thank you!

You'll never guess what though...I double checked and saw that I was using version 3.1.3_2 of Dramatic Doors for 1.20.1 (released on 3 November). After your comment, I decided to try v3.1.5 which was released just a couple of weeks later...and lo and behold, no more crash with Thingamajigs! Apologies, I have to admit I feel a little silly for not having tried the slightly newer version of your mod, lol. I still have the config set so that waterlogging is false, and I imagine it may crash again if I changed that, but yeah, I'm happy with this solution so I'll close this one up. 👍