search

Kitteh6660 / DramaticDoors

Minecraft Mod for Forge & Fabric: 3-block high doors, in every vanilla variety! End enderman discrimination!
MIT License
6 stars 7 forks source link

[BUG]Crashing with the mod: thingamajigs #94

Closed TreeFight closed 1 week ago

TreeFight commented 2 weeks ago

When using with the mod thingamajigs, the game will crash. Crash logs: https://gist.github.com/TreeFight/0e13709c7452b0a138a93894a1f6b58f I can confirm the crash is caused by the incompatibility of dramatic doors and thingamajigs, I tested all my mod one by one.

This is the link of the thingamajigs mod: https://www.curseforge.com/minecraft/mc-mods/blueys-thingamajigs

Kitteh6660 commented 2 weeks ago

This is strange, the errors pointed to Sodium. I may need to investigate.

TreeFight commented 2 weeks ago

This is strange, the errors pointed to Sodium. I may need to investigate.

In case you don't know, I'm playing 1.20.1 version with forge. No optifine, cause I use xenon (which is embeddium with some upgrade) and occlus instead.

Oh god, I upload the wrong crash logs, sorry. Please check the crash log again, I changed it.

Kitteh6660 commented 2 weeks ago

There is going to be a fix. I've created a PR over there: https://github.com/roberttkahelin8/thingmajigs/pull/15

For some reason, LockableDoor does not inherit all the properties from base door block, thus if any properties were added to base door, it will crash.

In the meantime, I could inject waterlogging.

TreeFight commented 2 weeks ago

There is going to be a fix. I've created a PR over there: roberttkahelin8/thingmajigs#15

For some reason, LockableDoor does not inherit all the properties from base door block, thus if any properties were added to base door, it will crash.

In the meantime, I could inject waterlogging.

I saw your Pull request. So should I just wait for thingmajigs to update? Or would you update dramatic doors recently?

Kitteh6660 commented 1 week ago

It's a matter of waiting for Thingamajigs to update!

I've applied a condition to check if Thingamajigs version is 1.7.2 or earlier then apply the waterlogging patch.