search

KittehOrg / KittehIRCClientLib

An IRC client library in Java
https://kitteh.dev/kicl/
MIT License
144 stars 34 forks source link

Removed 2 unnecessary stubbings in KickCommandTest.java #309

Closed ARUS2023 closed 9 months ago

ARUS2023 commented 1 year ago

In our analysis of the project, we observed that 1) 1 stubbing which stubbed toString method is created in KickCommandTest.before but never executed in 5 tests: KickCommandTest.noReasonAnymore, KickCommandTest.noReasonStrings, KickCommandTest.noTarget, KickCommandTest.wrongClientUser, KickCommandTest.reasonElements.

2) 1 stubbing which stubbed getNick method is created in KickCommandTest.before but never executed in 5 tests: KickCommandTest.noReasonAnymore, KickCommandTest.noReasonStrings, KickCommandTest.noTarget, KickCommandTest.wrongClientUser, KickCommandTest.toStringer.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

mbax commented 9 months ago

Strange bot.