KittehOrg / KittehIRCClientLib

An IRC client library in Java
https://kitteh.dev/kicl/
MIT License
146 stars 34 forks source link

Make args a List in ClientReceiveServerMessageEventBase #31

Closed bendem closed 9 years ago

bendem commented 9 years ago
22:25:28      bendem | mbaxter, why String[]? 
22:26:44    @mbaxter | bendem: Uh where
22:27:05    @mbaxter | oh, the arguments.
22:27:07      bendem | mbaxter, for all the args
22:27:41    @mbaxter | bendem: what's the better solution? ;)
22:28:26      bendem | List<String>? and return an immutable view instead of copying?
22:29:33      bendem | an array backed list is about the same price, but much nicer to use than an array that you always end up wrapping in a list anyway
22:30:15      bendem | not like it bothers me, I don't even know what args are
22:30:21      bendem | but just a thought seeing that diff
22:42:29    @mbaxter | bendem: Yeah... I should probably change that. make a ticket ^_^
22:42:30    @mbaxter | pls
22:42:33    @mbaxter | tkt pls
mbax commented 9 years ago

https://github.com/KittehOrg/KittehIRCClientLib/commit/acc83f3bcca93cc860481e66ebd8e556df643403