MAINT: Add R105 support for the WCE chat buttons, converting them into proper DOM buttons

bananarama92 commented 5 months ago

Matching the chat log changes from BondageProjects/Bondage-College#5073 (which replaced the entire things including the chat submit button with DOM elements), this PR converts the WCE chat buttons into DOM elements and stores them into a new dedicated button grid. With the grids collapsible nature it might even be worthwhile to show the buttons there unconditionally (rather than hiding them behind fbcSettings.antiGarbleChatOptions), but that's something that can always be deferred to a later date.

Examples

It's still a little bit rough (and I had expected Ben to not drag his feet as much for the yet to-be merged prev/next-button API...), but it is very much functional:

https://github.com/KittenApps/WCE/assets/105885570/9935c685-5f05-464b-96d2-eaa2c7d4d81d

netlify[bot] commented 5 months ago

Deploy Preview for wce ready!

Name	Link
Latest commit	5162427327b968ece12ee6463c53306a58a1d1d5
Latest deploy log	https://app.netlify.com/sites/wce/deploys/66676386b5325200081aeebd
Deploy Preview	https://deploy-preview-13--wce.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

KittenApps commented 5 months ago

Thank you! Looks good so far. My idea was to use an actual html select for the garble level, which could be full width above the other buttons. Also the option text should mention if we are in normal chat or whisper mode (like the current BackNextButton implementation) and it could be properly styled for dark mode too.

I'll look more into it tomorrow.

BTW: You should remove the || GameVersion.startsWith('R105') part in the disabled condition of the antiGarbleChatOptions setting too.

KittenApps / WCE